add retry or abort prompt to all connection tests

hub/onboard-spoke.sh

@@ -4,12 +4,40 @@ set -euo pipefail
 RCLONE_CONF="${HOME}/.config/rclone/rclone.conf"
 SSH_DIR="${HOME}/.ssh"
 
+if [ "$(id -u)" -eq 0 ]; then
+    echo -e "\033[0;31m[WARNING]\033[0m Running as root — keys will be written to /root/.ssh. Run as armbian instead."
+    exit 1
+fi
+mkdir -p "$SSH_DIR"
+touch "$SSH_DIR/known_hosts"
+chmod 700 "$SSH_DIR"
+chmod 600 "$SSH_DIR/known_hosts"
+
 RED='\033[0;31m'
 GREEN='\033[0;32m'
 YELLOW='\033[1;33m'
 CYAN='\033[0;36m'
 NC='\033[0m'
 
+retry_or_abort() {
+    local test_cmd="$1"
+    local fail_msg="$2"
+    while true; do
+        if eval "$test_cmd" 2>/dev/null; then
+            return 0
+        fi
+        echo ""
+        warn "$fail_msg"
+        echo -e "  ${YELLOW}[R]${NC} Retry   ${RED}[A]${NC} Abort"
+        read -rp "Choice: " CHOICE
+        case "${CHOICE,,}" in
+            r) info "Retrying..." ;;
+            a) die "Aborted." ;;
+            *) warn "Press R to retry or A to abort." ;;
+        esac
+    done
+}
+
 info()   { echo -e "${GREEN}[+]${NC} $*"; }
 warn()   { echo -e "${YELLOW}[!]${NC} $*"; }
 die()    { echo -e "${RED}[ERROR]${NC} $*" >&2; exit 1; }
@@ -36,11 +64,9 @@ KEYSCAN=$(ssh-keyscan -p "$TUNNEL_PORT" -H localhost 2>/dev/null)
 echo "$KEYSCAN" >> "$SSH_DIR/known_hosts"
 
 info "Verifying spoke is reachable on port $TUNNEL_PORT..."
-if ssh -o BatchMode=yes -o ConnectTimeout=10 -p "$TUNNEL_PORT" armbian@localhost exit 2>/dev/null; then
-    info "Spoke is reachable."
-else
-    warn "Could not verify spoke without a key yet — proceeding to key setup."
-fi
+retry_or_abort \
+    "ssh -o BatchMode=yes -o ConnectTimeout=10 -p \"$TUNNEL_PORT\" armbian@localhost exit" \
+    "Spoke not reachable on port $TUNNEL_PORT. Make sure the tunnel is up."
 
 header "Generating Hub SSH Key"
 if [ -f "$KEY_PATH" ]; then
@@ -57,11 +83,10 @@ ssh-copy-id -i "$KEY_PATH.pub" -p "$TUNNEL_PORT" armbian@localhost
 info "Key copied."
 
 header "Testing Hub -> Spoke Key Auth"
-if ssh -i "$KEY_PATH" -o BatchMode=yes -o ConnectTimeout=10 -p "$TUNNEL_PORT" armbian@localhost exit 2>/dev/null; then
-    info "Key auth to spoke successful."
-else
-    die "Key auth failed. Check authorized_keys on the spoke."
-fi
+retry_or_abort \
+    "ssh -i \"$KEY_PATH\" -o BatchMode=yes -o ConnectTimeout=10 -p \"$TUNNEL_PORT\" armbian@localhost exit" \
+    "Key auth failed. Check authorized_keys on the spoke."
+info "Key auth to spoke successful."
 
 header "Adding rclone Remote"
 if grep -q "\[${SPOKE_NAME}-remote\]" "$RCLONE_CONF" 2>/dev/null; then

setup.sh

@@ -16,6 +16,25 @@ YELLOW='\033[1;33m'
 CYAN='\033[0;36m'
 NC='\033[0m'
 
+retry_or_abort() {
+    local test_cmd="$1"
+    local fail_msg="$2"
+    while true; do
+        if eval "$test_cmd" 2>/dev/null; then
+            return 0
+        fi
+        echo ""
+        warn "$fail_msg"
+        echo -e "  ${YELLOW}[R]${NC} Retry   ${RED}[A]${NC} Abort"
+        read -rp "Choice: " CHOICE
+        case "${CHOICE,,}" in
+            r) info "Retrying..." ;;
+            a) die "Aborted." ;;
+            *) warn "Press R to retry or A to abort." ;;
+        esac
+    done
+}
+
 info()   { echo -e "${GREEN}[+]${NC} $*"; }
 warn()   { echo -e "${YELLOW}[!]${NC} $*"; }
 die()    { echo -e "${RED}[ERROR]${NC} $*" >&2; exit 1; }
@@ -100,17 +119,16 @@ case "$KEY_CHOICE" in
 esac
 
 info "Scanning hub host key..."
-sudo -u armbian ssh-keyscan -H "$HUB_HOST" >> "$SSH_DIR/known_hosts" 2>/dev/null
+sudo -u armbian touch "$SSH_DIR/known_hosts"
 chown armbian:armbian "$SSH_DIR/known_hosts"
 chmod 600 "$SSH_DIR/known_hosts"
+sudo -u armbian ssh-keyscan -H "$HUB_HOST" >> "$SSH_DIR/known_hosts" 2>/dev/null
 
 header "Testing SSH Connection"
 info "Testing connection to $HUB_HOST..."
-if sudo -u armbian ssh -i "$KEY_PATH" -o BatchMode=yes -o ConnectTimeout=10 "$HUB_USER@$HUB_HOST" exit 2>/dev/null; then
-    info "SSH connection successful."
-else
-    die "SSH connection to $HUB_HOST failed. Check that finn added your public key."
-fi
+retry_or_abort \
+    "sudo -u armbian ssh -i \"$KEY_PATH\" -o BatchMode=yes -o ConnectTimeout=10 \"$HUB_USER@$HUB_HOST\" exit" \
+    "SSH connection to $HUB_HOST failed. Check that finn added your public key."
 
 header "Finding Available Tunnel Port"
 info "Scanning for a free port on $HUB_HOST starting from $START_PORT..."