justin/guitar-teacher
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Open strings show no finger number, only hollow circle

Browse Source
This commit is contained in:
Sterling Archer
2026-06-14 22:21:17 -07:00
parent 8c15883cd8
commit bf5475e5c0
1 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
index.html
+11 -3
View File
@@ -433,11 +433,19 @@ function SongPlayer({ parts, detected, listening, onStartMic }) {
stroke={isOpen?(isHit?C.sage:isCur?C.amber:C.amber):"none"} stroke={isOpen?(isHit?C.sage:isCur?C.amber:C.amber):"none"}
strokeWidth={isOpen?2.5:0} strokeWidth={isOpen?2.5:0}
opacity={opacity}/> opacity={opacity}/>
{!isOpen && (
<text x={cx} y={cy+5} textAnchor="middle" fontSize={14} <text x={cx} y={cy+5} textAnchor="middle" fontSize={14}
fill={isOpen?(isHit?"#1A1A1F":isCur?"#1A1A1F":C.amber):"#1A1A1F"} fill={isHit?"#1A1A1F":isCur?"#1A1A1F":"#1A1A1F"}
fontWeight="900" fontFamily="monospace"> fontWeight="900" fontFamily="monospace">
{ni+1} {ni+1}
</text> </text>
)}
{isOpen && (isHit||isCur) && (
<text x={cx} y={cy+5} textAnchor="middle" fontSize={12}
fill="#1A1A1F" fontWeight="900" fontFamily="monospace">
0
</text>
)}
{isCur && ( {isCur && (
<text x={cx} y={cy-24} textAnchor="middle" fontSize={20}>🎸</text> <text x={cx} y={cy-24} textAnchor="middle" fontSize={20}>🎸</text>
)} )}
@@ -478,9 +486,9 @@ function SongPlayer({ parts, detected, listening, onStartMic }) {
const p = NOTE_FRET_MAP[n]; const p = NOTE_FRET_MAP[n];
return ( return (
<div key={i} style={{display:"flex",alignItems:"center",gap:3,fontSize:10,color:C.muted}}> <div key={i} style={{display:"flex",alignItems:"center",gap:3,fontSize:10,color:C.muted}}>
<span style={{color:C.amber,fontWeight:700}}>{i+1}</span> {p&&p.fret!==0&&<span style={{color:C.amber,fontWeight:700}}>{i+1}</span>}
<span style={{fontFamily:"monospace",color:C.text}}>{n}</span> <span style={{fontFamily:"monospace",color:C.text}}>{n}</span>
{p&&<span style={{color:C.muted}}>({STRING_NAMES[p.str]} fr{p.fret})</span>} {p&&<span style={{color:C.muted}}>{p.fret===0?"(open "+STRING_NAMES[p.str]+")":"("+STRING_NAMES[p.str]+" fr"+p.fret+")"}</span>}
</div> </div>
); );
})} })}