Use reference passing for EpdRenderer

src/CrossPointState.cpp

@@ -9,38 +9,27 @@
 constexpr uint8_t STATE_VERSION = 1;
 constexpr char STATE_FILE[] = "/sd/.crosspoint/state.bin";
 
-void CrossPointState::serialize(std::ostream& os) const {
-  serialization::writePod(os, STATE_VERSION);
-  serialization::writeString(os, openEpubPath);
+bool CrossPointState::saveToFile() const {
+  std::ofstream outputFile(STATE_FILE);
+  serialization::writePod(outputFile, STATE_VERSION);
+  serialization::writeString(outputFile, openEpubPath);
+  outputFile.close();
+  return true;
 }
 
-CrossPointState* CrossPointState::deserialize(std::istream& is) {
-  const auto state = new CrossPointState();
+bool CrossPointState::loadFromFile() {
+  std::ifstream inputFile(STATE_FILE);
 
   uint8_t version;
-  serialization::readPod(is, version);
+  serialization::readPod(inputFile, version);
   if (version != STATE_VERSION) {
     Serial.printf("CrossPointState: Unknown version %u\n", version);
-    return state;
+    inputFile.close();
+    return false;
   }
 
-  serialization::readString(is, state->openEpubPath);
-  return state;
-}
+  serialization::readString(inputFile, openEpubPath);
 
-void CrossPointState::saveToFile() const {
-  std::ofstream outputFile(STATE_FILE);
-  serialize(outputFile);
-  outputFile.close();
-}
-
-CrossPointState* CrossPointState::loadFromFile() {
-  if (!SD.exists(&STATE_FILE[3])) {
-    return new CrossPointState();
-  }
-
-  std::ifstream inputFile(STATE_FILE);
-  CrossPointState* state = deserialize(inputFile);
   inputFile.close();
-  return state;
+  return true;
 }